chore(agent): organized go based agent config and key into dedicated directory#5943
chore(agent): organized go based agent config and key into dedicated directory#5943ltan10 wants to merge 1 commit intoshellhub-io:masterfrom
Conversation
fbab19e to
a7beeba
Compare
a7beeba to
1e42d5b
Compare
Create directory if doesn't exist.
1e42d5b to
50f40b7
Compare
otavio
left a comment
There was a problem hiding this comment.
The biggest problem I foresee here is migrating the field-deployed agents.
So even though I agree with the idea of this change, we need to consider how we will migrate the existing agents to work with this new approach or provide a backward-compatible way for them to keep working.
How do you foresee solving this issue?
|
With all the testing. I've stumbled upon this myself. The only persistent remaining file is just Two methods for transition:
@otavio someone should be able to replicate my findings for confirmation. EDIT: |
|
@otavio You are correct that users using the tunnel to upgrade their agent will have their tunnel ceremoniously terminated when migrating from the runc binary to go-native binary. I tried sending the shell install script to background and including using nohup to ignore sighup. However still no luck as the child process executing the agent install did not appear to initiate. This observation was the same for an standalone agent upgrade made through the tunnel for the following situations
With all tunnels terminated when users used shellhub tunnel to upgrade the agent |
What kind of change does this PR introduce?
Description:
/etc/agent-agent